Repository navigation
add email configuration docs - #1682
Merged
phycodurus merged 9 commits intoSep 24, 2026
Merged
phycodurus merged 9 commits into
phycodurus merged 9 commits into
Conversation
The build upon tom_registrations README.md
jchate6
changed the base branch from
dev
to
1416-add-support-for-mfa-for-tom-user-logins
September 21, 2026 21:16
…-document-email-configuration
jchate6
added this pull request to stack #1683
September 21, 2026 21:33
jchate6
requested changes
Sep 23, 2026
jchate6
left a comment
Contributor
There was a problem hiding this comment.
I think some things could be better.
jchate6
approved these changes
Sep 24, 2026
jchate6
left a comment
Contributor
There was a problem hiding this comment.
It feels like you have generally ignored my more important comments about readability, especially where long bullet points are concerned.
I really don't think multi-line bullets should be included in documentation like this. They undermine the utility of bullets by not allowing users to skim short brief points of information to see what's relevant to them, and they are more difficult to read than complete sentences with surrounding context. That being said, I've made that opinion clear, and they are you're docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds email configuration docs. This was factored out of the MFA PR and ideally will merge into dev first.
closes #1681